Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/1184 #2760

Closed
wants to merge 7 commits into from
Closed

Issues/1184 #2760

wants to merge 7 commits into from

Conversation

CrisGuzmanS
Copy link
Contributor

Hello everyone! i have done the last activity of this issue. I will be attentive to any comments.

References

Description

email & password inputs have their corresponding autocomplete attributes.

Instructions for Reviewers

  1. Open the login menu.
  2. Inspect the email & password input
  3. You will see the autocomplete attribute "username" for email & "current-password" for email.
    image

List of changes in this PR:

  • email input has autocomplete="username"
  • password input has autocomplete="current-password"

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem
Copy link
Member

Hey @CrisGuzmanS I already added this fix to PR #2717 (containing a lot of other accessibility fixes) so I'm closing this as it's a duplicate 😅

@CrisGuzmanS
Copy link
Contributor Author

Ok @alexandrevryghem sorry, and thank you for the notice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deque Analysis] Login module's "serious" accessibility issues
2 participants